Add --kill-on-exit option #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add --kill-on-exit option which kills all tracees when the initial process exits. This option can be used to garbage collect detached tracees which may be left around and which would block unexpectedly the proot process from exiting. Add tests/test-killexit.sh unit test.
|
Hi! Can you please update the PR (with a small commit or by closing/opening it) so that Travis CI can run the tests and your new test too? If everything checks out we can merge the PR. |
|
I have push it with a small change for running the test with zsh. (status is a reserved keywork on zsh). |
|
@alkino can you point us to where you pushed these changes? |
|
I try to update this PR but I failed to it. |
YOoOsRi
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a --kill-on-exit option that kill all pending tracee processes when the main command (i.e. the command passed as proot argument, which is the first tracee created) exits.
This is useful for proot commands which are supposed to return without leaving detached processes around.
In particular for instance a command may not correctly wait detached processes and the effect is that proot will keep waiting for all tracee to complete.
Thus generally when launching a command which is not supposed to detach, it would be advised to use proot --kill-on-exit ...
NOTE; I suppose that it may be feasible to reimplement this as a plugin. Please comment on this.